jonmeredith commented on code in PR #1758:
URL: https://github.com/apache/cassandra/pull/1758#discussion_r932742685
##########
src/java/org/apache/cassandra/config/YamlConfigurationLoader.java:
##########
@@ -363,10 +365,12 @@ else if (result.getAnnotation(Deprecated.class) != null)
return new ForwardingProperty(result.getName(), result)
{
+ boolean allowsNull = result.getAnnotation(Nullable.class) !=
null;
+
@Override
public void set(Object object, Object value) throws Exception
{
- if (value == null && get(object) != null)
+ if (value == null && get(object) != null && !allowsNull)
Review Comment:
Understand about rabbit holes. I'd be happy with opening a follow up JIRA
and adding a comment referencing it in this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
