ekaterinadimitrova2 commented on code in PR #1754:
URL: https://github.com/apache/cassandra/pull/1754#discussion_r932504634
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -3186,7 +3281,10 @@ public static int getCacheLoadTimeout()
@VisibleForTesting
public static void setCacheLoadTimeout(int seconds)
{
- conf.cache_load_timeout = new DurationSpec.IntSecondsBound(seconds);
+ if (seconds < 0)
Review Comment:
Yeah, makes sense not to do conversions, absolutely, thanks. I will also add
more tests as @maedhorz suggested, I am actually working on special cases
loading from yaml and from fromMap (old and new names) and checking the
Settings Virtual Table for all Converters. And I think this is exactly what you
are looking for here. I will share commit later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
