ekaterinadimitrova2 commented on code in PR #1754:
URL: https://github.com/apache/cassandra/pull/1754#discussion_r932724500
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -153,18 +153,18 @@ public CompactionMetrics getMetrics()
*/
public RateLimiter getRateLimiter()
{
- setRate(DatabaseDescriptor.getCompactionThroughputMebibytesPerSec());
+ setRate(DatabaseDescriptor.getCompactionThroughputBytesPerSec());
return compactionRateLimiter;
}
/**
* Sets the rate for the rate limiter. When compaction_throughput is 0 or
node is bootstrapping,
* this sets the rate to Double.MAX_VALUE bytes per second.
- * @param throughPutMiBPerSec throughput to set in MiB/s
+ * @param throughputBytesPerSec throughput to set in B/s
*/
- public void setRate(final double throughPutMiBPerSec)
+ public void setRate(final double throughputBytesPerSec)
Review Comment:
This was actually originally throughputMbPerSec.
https://github.com/apache/cassandra/commit/5bb4bab12f8edfef95ed13cbabf8c0f377986065#diff-f7dd0237c343649f70b7ec9fefd7f6941a40b5164fd6063dce00fc09d2c234a7L163
It is not in the `CompactionManagerMbean` but it is public so not sure
whether I have to worry about it actually...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
