josh-mckenzie commented on code in PR #1751:
URL: https://github.com/apache/cassandra/pull/1751#discussion_r932543242
##########
src/java/org/apache/cassandra/db/compaction/TimeWindowCompactionStrategy.java:
##########
@@ -56,6 +58,7 @@ public class TimeWindowCompactionStrategy extends
AbstractCompactionStrategy
private final Set<SSTableReader> sstables = new HashSet<>();
private long lastExpiredCheck;
private long highestWindowSeen;
+ private Map<Long, Integer> sstableCountByBuckets = Collections.emptyMap();
Review Comment:
Subtle; good catch. This definitely opens this up to being accessed by
multiple thread contexts. This tweak should give us slightly more up-to-date
information in what we see via JMX if it just so happens to race w/the repair
manager or compaction managers picking their next tasks. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
