josh-mckenzie commented on code in PR #1751:
URL: https://github.com/apache/cassandra/pull/1751#discussion_r932546805
##########
src/java/org/apache/cassandra/db/ColumnFamilyStoreMBean.java:
##########
@@ -217,6 +217,12 @@ public List<String> importNewSSTables(Set<String> srcPaths,
*/
public long[] getPerLevelSizeBytes();
+ /**
+ * @return sstable count for each bucket in TWCS. null unless time window
compaction is used.
+ * array index corresponds to bucket(int[0] is for most recent,
...).
Review Comment:
I can't speak to the intent of the original author (will update commit
message to reflect that it was Stefan's work; can check w/him), however the
current shape of things is recency left to right, levels left to right, level 0
corresponding to "newest".
```
array index corresponds to level(int[0] is for level 0, ...)
array index corresponds to bucket(int[0] is for most recent, ...).
```
I don't really have an opinion on it excepting the current formatting
provides logical symmetry between the two JMX calls and I like consistency even
at the expense of intuition sometimes. 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
