ekaterinadimitrova2 commented on code in PR #1754:
URL: https://github.com/apache/cassandra/pull/1754#discussion_r932764168
##########
src/java/org/apache/cassandra/config/DataRateSpec.java:
##########
@@ -252,6 +253,21 @@ public LongBytesPerSecondBound(long bytesPerSecond)
{
this(bytesPerSecond, BYTES_PER_SECOND);
}
+
+ // this one should be used only for backward compatibility for
stream_throughput_outbound and inter_dc_stream_throughput_outbound
+ // which were in megabits per second in 4.0. Do not start using it for
any new properties
+ public static LongBytesPerSecondBound
megabitsPerSecondInBytesPerSecond(long megabitsPerSecond)
+ {
+ final double BYTES_PER_MEGABIT = 125_000;
+ double bytesPerSecond = (double) megabitsPerSecond *
BYTES_PER_MEGABIT;
Review Comment:
Depends on whether we keep the `IntMebibytesBound`. I think probably we
don't but we would want `IntBytesBound` at some point. I guess that one we can
add in trunk so people can use it. We do not expect new properties in 4.1
anymore? The question is what do we want in this ticket... remove also
IntMebibytesBound and switch to long in DataRateSpec, but not in the
DataRateUnit? And people need to be clear they need to use double for any new
getters that will return rounded value in bigger than bytes unit....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
