ekaterinadimitrova2 commented on code in PR #1759:
URL: https://github.com/apache/cassandra/pull/1759#discussion_r936337383
##########
test/unit/org/apache/cassandra/config/YamlConfigurationLoaderTest.java:
##########
@@ -311,6 +311,10 @@ public void converters()
assertThatThrownBy(() ->
from("stream_throughput_outbound_megabits_per_sec",
-2).stream_throughput_outbound.toMegabitsPerSecondAsInt())
.hasRootCauseInstanceOf(IllegalArgumentException.class)
.hasRootCauseMessage("Invalid data rate: value must be non-negative");
+
+ // NEGATIVE_DATA_STORAGE_INT
+ assertThat(from("sstable_preemptive_open_interval_in_mb",
"1").sstable_preemptive_open_interval.toMebibytes()).isEqualTo(1);
+ assertThat(from("sstable_preemptive_open_interval_in_mb",
-2).sstable_preemptive_open_interval).isNull();
}
Review Comment:
By the way, I just realized that this PR is still open as I was having
trouble to close any PRs (hitting some weird Github bug) but the work was
already accepted and committed last week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
