ekaterinadimitrova2 commented on code in PR #1759:
URL: https://github.com/apache/cassandra/pull/1759#discussion_r936342344
##########
test/unit/org/apache/cassandra/config/YamlConfigurationLoaderTest.java:
##########
@@ -311,6 +311,10 @@ public void converters()
assertThatThrownBy(() ->
from("stream_throughput_outbound_megabits_per_sec",
-2).stream_throughput_outbound.toMegabitsPerSecondAsInt())
.hasRootCauseInstanceOf(IllegalArgumentException.class)
.hasRootCauseMessage("Invalid data rate: value must be non-negative");
+
+ // NEGATIVE_DATA_STORAGE_INT
+ assertThat(from("sstable_preemptive_open_interval_in_mb",
"1").sstable_preemptive_open_interval.toMebibytes()).isEqualTo(1);
+ assertThat(from("sstable_preemptive_open_interval_in_mb",
-2).sstable_preemptive_open_interval).isNull();
}
Review Comment:
`It is just a matter of test point choices. I would have chosen 0 and -1 to
exhibit the change at the boundary. But if you think the test is sufficient, I
have no objections to proceeding.`
It seems our last comments were posted at the same time.
Thank for your feedback. I can incorporate it later, this commit was already
done but I will keep in mind to add it as part of the next one. I don’t see any
particular lack of testing here but I understand your point to exhibit the
exact boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
