belliottsmith commented on code in PR #6:
URL: https://github.com/apache/cassandra-accord/pull/6#discussion_r937090705
##########
accord-core/src/main/java/accord/messages/Callback.java:
##########
@@ -9,5 +9,7 @@
public interface Callback<T>
{
void onSuccess(Id from, T response);
- void onFailure(Id from, Throwable throwable);
+ default void onSlowResponse(Id from) {}
+ void onFailure(Id from, Throwable failure);
+ void onCallbackFailure(Throwable failure);
Review Comment:
I take it you're referring to the maelstrom implementation? You're right
though, these should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
