belliottsmith commented on code in PR #6:
URL: https://github.com/apache/cassandra-accord/pull/6#discussion_r937240707
##########
accord-core/src/main/java/accord/utils/Timestamped.java:
##########
@@ -17,4 +17,10 @@ public static <T> Timestamped<T> merge(Timestamped<T> a,
Timestamped<T> b)
{
return a.timestamp.compareTo(b.timestamp) >= 0 ? a : b;
}
+
+ @Override
+ public String toString()
Review Comment:
Maybe, though I think when debugging it's important to balance information,
and it's easier for humans to parse maps with just the value string IME. It's
rare the timestamp is important, so I preferred to prioritise the more common
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]