maedhroz commented on code in PR #1769: URL: https://github.com/apache/cassandra/pull/1769#discussion_r938431453
########## src/java/org/apache/cassandra/tools/BulkLoadConnectionFactory.java: ########## @@ -70,4 +70,9 @@ private NettyStreamingChannel create(OutboundConnectionSettings template, int me Review Comment: If a `connectTo` is always set in this last `create()` overload, the comment in the second `create()` is incorrect, given the preferred address is always overridden. From an API perspective, the `preferred` address is completely ignored, and the second `create()` overload is useless, and we could just remove it. (The `Factory` interface has a default method that ignores `preferred`.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
