maedhroz commented on code in PR #1769: URL: https://github.com/apache/cassandra/pull/1769#discussion_r938438411
########## src/java/org/apache/cassandra/tools/BulkLoadConnectionFactory.java: ########## @@ -70,4 +70,9 @@ private NettyStreamingChannel create(OutboundConnectionSettings template, int me Review Comment: The comment in the second `create()` method is incorrect now. The preferred address is always ignored, not just ignored when encryption is enabled. We can't make this compatible w/ `EC2Snitch` (using the preferred address), so the only reason that overload exists is so we don't call the `NettyStreamingConnectionFactory` implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
