belliottsmith commented on PR #6: URL: https://github.com/apache/cassandra-accord/pull/6#issuecomment-1214179514
I've pushed some further changes to improve javadoc, and in the process noticed that the `Deps.Builder` is unnecessarily costly for most use cases - since we only use it when building from `TxnId` that are visited in ascending order we can build into a single `int[]` and simply flip it. I have chosen not to implement caching of these for now, but it's a trivial TODO for later. We could consider removing the `unorderedBuilder` entirely, as it's only needed in `DepsTest.generate` and `accord.maelstrom.Json` - both of which could readily manage without. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
