ekaterinadimitrova2 commented on code in PR #1788:
URL: https://github.com/apache/cassandra/pull/1788#discussion_r948142710
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -835,13 +838,23 @@ default int upgradeSSTables(String keyspaceName, boolean
excludeCurrentVersion,
/** Returns the granularity of the collation index of rows within a
partition **/
public int getColumnIndexSizeInKiB();
- /** Sets the granularity of the collation index of rows within a partition
**/
+ /**
+ * @deprecated use setColumnIndexSizeInKiB instead as it will not throw
non-standard exceptions
+ * Sets the granularity of the collation index of rows within a partition
+ */
public void setColumnIndexSize(int columnIndexSizeInKB);
Review Comment:
Same as before, let's add also @Deprecated
##########
src/java/org/apache/cassandra/service/ActiveRepairServiceMBean.java:
##########
@@ -34,9 +34,14 @@
@Deprecated
public int getRepairSessionSpaceInMegabytes();
+ /**
+ * @deprecated use setRepairSessionSpaceInMiB instead as it will not throw
non-standard exceptions
+ */
Review Comment:
We need to add @Deprecated here too, not only in Java doc and the actual
implementation
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -835,13 +838,23 @@ default int upgradeSSTables(String keyspaceName, boolean
excludeCurrentVersion,
/** Returns the granularity of the collation index of rows within a
partition **/
public int getColumnIndexSizeInKiB();
- /** Sets the granularity of the collation index of rows within a partition
**/
+ /**
+ * @deprecated use setColumnIndexSizeInKiB instead as it will not throw
non-standard exceptions
+ * Sets the granularity of the collation index of rows within a partition
+ */
public void setColumnIndexSize(int columnIndexSizeInKB);
+ /** Sets the granularity of the collation index of rows within a partition
**/
+ public void setColumnIndexSizeInKiB(int columnIndexSizeInKiB);
/** Returns the threshold for skipping the column index when caching
partition info **/
public int getColumnIndexCacheSize();
- /** Sets the threshold for skipping the column index when caching
partition info **/
+ /**
+ * @deprecated use setColumnIndexCacheSizeInKiB instead as it will not
throw non-standard exceptions
+ * Sets the threshold for skipping the column index when caching partition
info
+ */
Review Comment:
@Deprecated to be added
##########
src/java/org/apache/cassandra/service/StorageService.java:
##########
@@ -4525,6 +4525,7 @@ public List<String> getParentRepairStatus(int cmd)
ImmutableList.<String>builder().add(pair.left.name()).addAll(pair.right).build();
}
+ @Deprecated
Review Comment:
I think @Override was missed before and we can use the opportunity to add it
maybe?
##########
src/java/org/apache/cassandra/service/StorageServiceMBean.java:
##########
@@ -850,8 +863,13 @@ default int upgradeSSTables(String keyspaceName, boolean
excludeCurrentVersion,
/** Returns the threshold for warning queries due to a large batch size */
public int getBatchSizeWarnThreshold();
- /** Sets the threshold for warning queries due to a large batch size */
+ /**
+ * @deprecated use setBatchSizeWarnThresholdInKiB instead as it will not
throw non-standard exceptions
+ * Sets the threshold for warning queries due to a large batch size
+ */
Review Comment:
Same @Deprecated to be added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
