ekaterinadimitrova2 commented on code in PR #1788:
URL: https://github.com/apache/cassandra/pull/1788#discussion_r964276209
##########
src/java/org/apache/cassandra/service/ActiveRepairService.java:
##########
@@ -297,18 +298,44 @@ public int getRepairSessionSpaceInMegabytes()
return DatabaseDescriptor.getRepairSessionSpaceInMiB();
}
+ @Deprecated
@Override
public void setRepairSessionSpaceInMebibytes(int sizeInMebibytes)
{
DatabaseDescriptor.setRepairSessionSpaceInMiB(sizeInMebibytes);
}
+ @Deprecated
@Override
public int getRepairSessionSpaceInMebibytes()
{
return DatabaseDescriptor.getRepairSessionSpaceInMiB();
}
+ @Override
+ public void setRepairSessionSpaceInMiB(int sizeInMebibytes)
+ {
+ try
+ {
+ DatabaseDescriptor.setRepairSessionSpaceInMiB(sizeInMebibytes);
+ }
+ catch (ConfigurationException e)
+ {
+ throw new IllegalArgumentException(e.getMessage());
Review Comment:
This would be a precedent, I can't imagine putting the Stacktrace as an
error message in JConsole, @dcapwell ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]