belliottsmith commented on code in PR #10:
URL: https://github.com/apache/cassandra-accord/pull/10#discussion_r990698101
##########
accord-core/src/main/java/accord/messages/Apply.java:
##########
@@ -54,15 +63,59 @@ public Apply(Node.Id to, Topologies topologies, TxnId
txnId, Txn txn, Key homeKe
this.result = result;
}
+ @VisibleForImplementation
+ public Apply(Keys scope, long waitForEpoch, TxnId txnId, Txn txn, Key
homeKey, Timestamp executeAt, Deps deps, Writes writes, Result result)
+ {
+ super(scope, waitForEpoch);
+ this.txnId = txnId;
+ this.txn = txn;
+ this.homeKey = homeKey;
+ this.executeAt = executeAt;
+ this.deps = deps;
+ this.writes = writes;
+ this.result = result;
+ }
+
+ static Future<Void> waitAndReduce(Future<Void> left, Future<Void> right)
Review Comment:
Dude, there is no disrespect here. I believe I am the primary author of this
work, and I do not believe it is disrespectful for me to claim it. I also think
when there is an _impasse_ with incompatible approaches to design, it is not
unreasonable for a primary author to suggest their design approach should win
out. You appear to disagree, but there is no disrespect.
Regarding this dispute, I do not enjoy insisting on changes any more than
you enjoy pushing back. But, we cannot have totally conflicting approaches to
design. If you disagree, and believe I have zero authority on the matter, then
we may have to escalate to some other arbiter - that is another option I
floated.
I will note, that your claims of improved type safety are weaker than you
think. A serious problem with `Future` is failing to handle exceptional
completion - and this _is_ required by the type system for callbacks. This is a
much bigger issue than any of the very minor - easily linted - concerns you
have raised about callbacks. So, I think even on the issue of compiler
assistance `Future` is notably _worse_ than a callback, since I have provided
multiple mitigations to your concerns with callbacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
