frankgh opened a new pull request, #41: URL: https://github.com/apache/cassandra-sidecar/pull/41
In this commit, we introduce the JMX foundation in Sidecar to enable the ability to communicate with the Cassandra process. This commit adds new configuration parameters to configure the a `org.apache.cassandra.sidecar.common.JmxClient`. This client is available as part of the Cassandra delegate. A new interface is introduced and exposed through the `org.apache.cassandra.sidecar.common.ICassandraAdapter`. The new interface `StorageOperations` is intended to interface with the Cassandra StorageService. This commit provides an example implementation of the `takeSnapshot` method, which is also found in the Cassandra code base. This should allow us to interact with the Cassandra process to create snapshots. A fix is required in the `CassandraSidecarDaemon` class, where the `healthCheck` runs the first time only after the configured health check frequency (millis) has passed. This causes issues in the unit tests as well as the actual execution of the service, as the `adapter` will be `null` until the first health check is performed. To fix this issue, we perform a health check right after the server successfully starts up. Additional integration tests are added for testing the JMX integration with Cassandra. In the test, we spin up a new Cassandra container using `testcontainers` and we perform validation against the StorageService in Cassandra. Co-authored-by: Doug Rohrer <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
