yifan-c commented on code in PR #41: URL: https://github.com/apache/cassandra-sidecar/pull/41#discussion_r1015939206
########## cassandra40/src/main/java/org/apache/cassandra/sidecar/cassandra40/StorageJmxOperations.java: ########## @@ -0,0 +1,18 @@ +package org.apache.cassandra.sidecar.cassandra40; + +import java.util.Map; + +/** + * An interface that pulls a method from the Cassandra Storage Service Proxy + */ +interface StorageJmxOperations Review Comment: Why it is in `cassandra40`? Do you expect it to be different in a different cassandra release? ########## cassandra40/src/main/java/org/apache/cassandra/sidecar/cassandra40/Cassandra40StorageOperations.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.cassandra40; + +import java.util.Map; + +import org.apache.cassandra.sidecar.common.JmxClient; +import org.apache.cassandra.sidecar.common.StorageOperations; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +import static java.util.Objects.requireNonNull; + +/** + * An implementation of the {@link StorageOperations} that interfaces with Cassandra 4.0 + */ +public class Cassandra40StorageOperations implements StorageOperations +{ + private static final String STORAGE_SERVICE_OBJ_NAME = "org.apache.cassandra.db:type=StorageService"; + private final JmxClient jmxClient; + + /** + * Creates a new instance with the provided {@link JmxClient} + * + * @param jmxClient the JMX client used to communicate with the Cassandra instance + */ + public Cassandra40StorageOperations(JmxClient jmxClient) + { + this.jmxClient = jmxClient; + } + + /** + * {@inheritDoc} + */ + @Override + public void takeSnapshot(@NotNull String tag, @NotNull String keyspace, @NotNull String table, + @Nullable Map<String, String> options) + { + requireNonNull(tag, "snapshot tag must be non-null"); + requireNonNull(keyspace, "keyspace for the must be non-null"); + requireNonNull(table, "table must be non-null"); Review Comment: 👍 to actually enforce the validation for `@NotNull` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
