belliottsmith commented on code in PR #7: URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1013045028
########## accord-core/src/main/java/accord/primitives/KeyRange.java: ########## @@ -18,29 +18,31 @@ package accord.primitives; -import accord.api.Key; - +import accord.api.RoutingKey; import accord.utils.SortedArrays; +import accord.utils.SortedArrays.Search; + import com.google.common.base.Preconditions; import java.util.Objects; -import static accord.utils.SortedArrays.Search.*; +import static accord.utils.SortedArrays.Search.CEIL; +import static accord.utils.SortedArrays.Search.FAST; /** * A range of keys */ -public abstract class KeyRange implements Comparable<Key> +public abstract class KeyRange implements Comparable<RoutingKey> Review Comment: Agreed. I rename it to simply `Range` in `routables`. I considered calling it a `RoutingRange` to allow for later a `KeyRange` but decided simply `Range` would suffice for now, and we could refactor in future when we need a `KeyRange`. Open to suggestions for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
