belliottsmith commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1012848817
##########
accord-core/src/main/java/accord/messages/PreAccept.java:
##########
@@ -121,7 +142,7 @@ default MessageType type()
return MessageType.PREACCEPT_RSP;
}
- boolean isOK();
+ boolean isOk();
}
public static class PreAcceptOk implements PreAcceptReply
Review Comment:
I decided no, to avoid confusion with situations where PartialDeps represent
a complete set of deps for a range (in this case, they are being assembled). We
could introduce a new concept _like_ {{PartialDeps}} to represent this
situation, but I'm not sure it's super valuable.
##########
accord-core/src/main/java/accord/messages/PreAccept.java:
##########
@@ -121,7 +142,7 @@ default MessageType type()
return MessageType.PREACCEPT_RSP;
}
- boolean isOK();
+ boolean isOk();
}
public static class PreAcceptOk implements PreAcceptReply
Review Comment:
I decided no, to avoid confusion with situations where `PartialDeps`
represent a complete set of deps for a range (in this case, they are being
assembled). We could introduce a new concept _like_ `PartialDeps` to represent
this situation, but I'm not sure it's super valuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
