belliottsmith commented on code in PR #1951:
URL: https://github.com/apache/cassandra/pull/1951#discussion_r1014289307
##########
src/java/org/apache/cassandra/service/accord/store/StoredSet.java:
##########
@@ -179,11 +179,17 @@ public long estimatedSizeOnHeap(ToLongFunction<T> measure)
return size;
}
- public static class Navigable<T extends Comparable<?>> extends
StoredSet<T, NavigableSet<T>>
+ public interface Changes<T>
Review Comment:
All of the `StoredSet` things are pretty tightly coupled to `AsyncWriter`,
and the implementations are `StoredSet`?
I wouldn't agonise over this personally, though, as it probably won't
survive Blake's refactors (or not for long)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
