belliottsmith commented on code in PR #1951:
URL: https://github.com/apache/cassandra/pull/1951#discussion_r1014622643
##########
src/java/org/apache/cassandra/service/accord/AccordCommand.java:
##########
@@ -524,22 +535,29 @@ public Timestamp executeAt()
}
@Override
- public void executeAt(Timestamp timestamp)
+ public Txn.Kind kind()
+ {
+ PartialTxn txn = partialTxn.get();
+ return txn == null ? null : txn.kind();
Review Comment:
So we shouldn't actually need this null check, since the only place this is
used is from the CommandsForKey, and we don't register ourselves with this
until we have been pre-accepted and know the transaction definition (in order
to know the keys we need to register with). So I think it is fine to leave this
alone for now, and simply remove the null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
