aweisberg commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1014454024
##########
accord-core/src/main/java/accord/impl/InMemoryCommand.java:
##########
@@ -218,21 +230,23 @@ public Status status()
}
@Override
- public void status(Status status)
+ public void setStatus(Status status)
{
this.status = status;
}
@Override
- public boolean isGloballyPersistent()
+ public Durability durability()
{
- return isGloballyPersistent;
+ if (status.hasBeen(PreApplied) && durability == NotDurable)
Review Comment:
Why didn't we `setDurability` to local when transitioning to `PreApplied`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
