aweisberg commented on code in PR #7: URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1014467728
########## accord-core/src/main/java/accord/coordinate/CheckOn.java: ########## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package accord.coordinate; + +import java.util.function.BiConsumer; + +import accord.local.*; +import accord.primitives.*; +import accord.utils.MapReduceConsume; +import com.google.common.base.Preconditions; + +import accord.api.RoutingKey; +import accord.local.Command.ApplyOutcome; +import accord.local.Command.CommitOutcome; +import accord.local.Node.Id; +import accord.messages.CheckStatus.CheckStatusOk; +import accord.messages.CheckStatus.CheckStatusOkFull; +import accord.messages.CheckStatus.IncludeInfo; +import com.google.common.collect.Iterables; + +import java.util.Collections; + +import static accord.local.PreLoadContext.contextFor; +import static accord.local.Status.*; +import static accord.local.Status.ReplicationPhase.*; + +/** + * Check on the status of a transaction. Returns early once enough information has been achieved to meet the requested + * status for the requested {@code route}. + * + * If a command is durable (i.e. executed on a majority on all shards) this is sufficient to replicate the command locally. + */ +public class CheckOn extends CheckShards Review Comment: Makes sense to me that these are no these are not the same thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
