aweisberg commented on code in PR #1951:
URL: https://github.com/apache/cassandra/pull/1951#discussion_r1014484109
##########
src/java/org/apache/cassandra/service/accord/AccordCommand.java:
##########
@@ -116,53 +119,52 @@ boolean isReadOnly()
}
}
- private final AccordCommandStore commandStore;
private final TxnId txnId;
private final int instanceCount = INSTANCE_COUNTER.getAndIncrement();
- public final StoredValue<Key> homeKey;
- public final StoredValue<Key> progressKey;
- public final StoredValue<Txn> txn;
+ public final StoredValue<AbstractRoute> route;
+ public final StoredValue<RoutingKey> homeKey;
+ public final StoredValue<RoutingKey> progressKey;
+ public final StoredValue<PartialTxn> partialTxn;
public final StoredValue<Ballot> promised;
public final StoredValue<Ballot> accepted;
public final StoredValue<Timestamp> executeAt;
- public final StoredValue<Deps> deps;
+ public final StoredValue<PartialDeps> partialDeps;
public final StoredValue<Writes> writes;
public final StoredValue<Result> result;
public final StoredValue.HistoryPreserving<Status> status;
- public final StoredBoolean isGloballyPersistent;
+ public final StoredValue<Durability> durability;
- public final StoredNavigableMap<TxnId, ByteBuffer> waitingOnCommit;
- public final StoredNavigableMap<TxnId, ByteBuffer> waitingOnApply;
+ public final StoredSet.Navigable<TxnId> waitingOnCommit;
+ public final StoredNavigableMap<Timestamp, TxnId> waitingOnApply;
+ public final StoredSet.Navigable<TxnId> blockingCommitOn;
+ public final StoredSet.Navigable<TxnId> blockingApplyOn;
public final StoredSet.DeterministicIdentity<ListenerProxy>
storedListeners;
private final Listeners transientListeners;
- public final StoredSet.Navigable<TxnId> blockingCommitOn;
- public final StoredSet.Navigable<TxnId> blockingApplyOn;
-
- public AccordCommand(AccordCommandStore commandStore, TxnId txnId)
+ public AccordCommand(TxnId txnId)
{
logger.trace("Instantiating new command {} @ {}", txnId,
instanceHash());
- this.commandStore = commandStore;
this.txnId = txnId;
- homeKey = new StoredValue<>(kind());
- progressKey = new StoredValue<>(kind());
- txn = new StoredValue<>(kind());
- promised = new StoredValue<>(kind());
- accepted = new StoredValue<>(kind());
- executeAt = new StoredValue<>(kind());
- deps = new StoredValue<>(kind());
- writes = new StoredValue<>(kind());
- result = new StoredValue<>(kind());
- status = new StoredValue.HistoryPreserving<>(kind());
- isGloballyPersistent = new StoredBoolean(kind());
- waitingOnCommit = new StoredNavigableMap<>(kind());
- waitingOnApply = new StoredNavigableMap<>(kind());
- storedListeners = new StoredSet.DeterministicIdentity<>(kind());
+ homeKey = new StoredValue<>(rw());
Review Comment:
That makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
