aweisberg commented on code in PR #1951:
URL: https://github.com/apache/cassandra/pull/1951#discussion_r1015650719


##########
src/java/org/apache/cassandra/service/accord/db/AccordUpdate.java:
##########
@@ -867,27 +913,26 @@ public AccordUpdate deserialize(DataInputPlus in, int 
version) throws IOExceptio
         public long serializedSize(AccordUpdate update, int version)
         {
             long size = KeySerializers.keys.serializedSize(update.keys, 
version);
-
-            size += TypeSizes.sizeof(update.updates.length);
             for (ByteBuffer buffer : update.updates)
                 size += ByteBufferUtil.serializedSizeWithVIntLength(buffer);
-
-            size += TypeSizes.sizeof(update.predicates.length);
             for (ByteBuffer buffer : update.predicates)
                 size += ByteBufferUtil.serializedSizeWithVIntLength(buffer);
-
             return size;
         }
     };
 
-    private static <T> ByteBuffer serialize(T item, IVersionedSerializer<T> 
serializer)
+    private static <T> ByteBuffer toSerializedValueArray(List<T> items, int 
start, int end, IVersionedSerializer<T> serializer, int version)

Review Comment:
   ```suggestion
       private static <T> ByteBuffer toSerializedValue(List<T> items, int 
start, int end, IVersionedSerializer<T> serializer, int version)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to