Maxwell-Guo commented on code in PR #2047:
URL: https://github.com/apache/cassandra/pull/2047#discussion_r1050546443
##########
src/java/org/apache/cassandra/cql3/UntypedResultSet.java:
##########
@@ -351,7 +351,11 @@ public ByteBuffer getBlob(String column)
public String getString(String column)
{
- return UTF8Type.instance.compose(data.get(column));
Review Comment:
I modify all other comment, but for this ,I should left it unchangede. When
we upgrade from previous version that have not got the new added
compaction_type column , the data.get(column) will return null ,and so a npe
will appears, we can see the getInt and getUUID method below ,they have
consider the case of null value.
Firstly , I considered changing all the methods of the corresponding type of
get method to consider the case where value is null, but I gave up later. I
thought it would be more appropriate to open a new jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
