smiklosovic commented on code in PR #2047:
URL: https://github.com/apache/cassandra/pull/2047#discussion_r1050556046
##########
src/java/org/apache/cassandra/cql3/UntypedResultSet.java:
##########
@@ -351,7 +351,11 @@ public ByteBuffer getBlob(String column)
public String getString(String column)
{
- return UTF8Type.instance.compose(data.get(column));
Review Comment:
You can use `public boolean has(String column)` in that class to check if it
is null and if it is not then you call `getString` otherwise you return null.
It is not necessary to change this method.
It is ok to open new ticket to investigate if we should not solve this in
more robust manner but that is not objective of this ticket.
##########
src/java/org/apache/cassandra/cql3/UntypedResultSet.java:
##########
@@ -351,7 +351,11 @@ public ByteBuffer getBlob(String column)
public String getString(String column)
{
- return UTF8Type.instance.compose(data.get(column));
Review Comment:
@Maxwell-Guo You can use `public boolean has(String column)` in that class
to check if it is null and if it is not then you call `getString` otherwise you
return null. It is not necessary to change this method.
It is ok to open new ticket to investigate if we should not solve this in
more robust manner but that is not objective of this ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
