aweisberg commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1063768702
##########
src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java:
##########
@@ -257,6 +315,55 @@ else if (otherValue == null)
}
return operator.isSatisfiedBy(type, otherValue, value);
}
+
+ void checkForUnsetValues(List<ByteBuffer> values)
Review Comment:
It's probably redundant, but that is such a fast thing to check at runtime I
think it's fine to do it in both?
I added this check and moved it earlier because I was unsure if we had those
unset values in practice and in which types of bounds. It's a little easier to
find out the unset value is unset when the bound is constructed rather than
later when it is applied.
Don't feel strongly either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
