aweisberg commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1063776510


##########
src/java/org/apache/cassandra/service/accord/txn/TxnUpdate.java:
##########
@@ -185,6 +178,7 @@ public Write apply(Data data)
         return new TxnWrite(updates);
     }
 
+    // Should we serialize the conditionResult?

Review Comment:
   The conclusion here was that we don't need to. At the coordinator it will 
not be recomputed in memory because it is memoized and on recovery it is safe 
for a recovery coordinator to recompute it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to