aweisberg commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1063828258
##########
src/java/org/apache/cassandra/service/accord/txn/TxnQuery.java:
##########
@@ -49,17 +54,47 @@ public Result compute(TxnId txnId, Data data, @Nullable
Read read, @Nullable Upd
public static final TxnQuery NONE = new TxnQuery()
{
+ @Override
+ protected byte type()
+ {
+ return 2;
+ }
+
@Override
public Result compute(TxnId txnId, Data data, @Nullable Read read,
@Nullable Update update)
{
return new TxnData();
}
};
+ public static final TxnQuery CONDITION = new TxnQuery()
+ {
+ @Override
+ protected byte type()
+ {
+ return 3;
+ }
+
+ @Override
+ public Result compute(TxnId txnId, Data data, @Nullable Read read,
@Nullable Update update)
Review Comment:
Huh, yeah copy paste error from the others. Accord says that `Data` is also
nullable in the interface.
I changed it and added null preconditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
