smiklosovic commented on code in PR #2047:
URL: https://github.com/apache/cassandra/pull/2047#discussion_r1067947155


##########
src/java/org/apache/cassandra/tools/nodetool/stats/CompactionHistoryHolder.java:
##########
@@ -54,8 +54,9 @@ private static class CompactionHistoryRow implements 
Comparable<CompactionHistor
         private final long bytesIn;
         private final long bytesOut;
         private final String rowMerged;
+        private final String compactionType;
 
-        CompactionHistoryRow(String id, String ksName, String cfName, long 
compactedAt, long bytesIn, long bytesOut, String rowMerged)
+        CompactionHistoryRow(String id, String ksName, String cfName, long 
compactedAt, long bytesIn, long bytesOut, String rowMerged, String 
compactionType)

Review Comment:
   @Maxwell-Guo you have not changed name of this property to 
`compactionProperties`.



##########
src/java/org/apache/cassandra/tools/nodetool/stats/CompactionHistoryHolder.java:
##########
@@ -64,6 +65,7 @@ private static class CompactionHistoryRow implements 
Comparable<CompactionHistor
             this.bytesIn = bytesIn;
             this.bytesOut = bytesOut;
             this.rowMerged = rowMerged;
+            this.compactionType = compactionType;

Review Comment:
   @Maxwell-Guo you have not changed name of this property to 
`compactionProperties`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to