smiklosovic commented on code in PR #2047:
URL: https://github.com/apache/cassandra/pull/2047#discussion_r1067953437
##########
src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java:
##########
@@ -24,16 +24,17 @@
import org.apache.cassandra.cql3.UntypedResultSet;
import org.apache.cassandra.db.marshal.Int32Type;
import org.apache.cassandra.db.marshal.LongType;
+import org.apache.cassandra.db.marshal.UTF8Type;
import org.apache.cassandra.utils.FBUtilities;
public class CompactionHistoryTabularData
{
private static final String[] ITEM_NAMES = new String[]{ "id",
"keyspace_name", "columnfamily_name", "compacted_at",
- "bytes_in",
"bytes_out", "rows_merged", "compaction_type" };
+ "bytes_in",
"bytes_out", "rows_merged", "compaction_properties" };
Review Comment:
@jacek-lewandowski I think map is just fine here with compaction_properties
representing it. Everytime we add an entry we would need to update this. Was
not the primary goal of map introduction to actually have something nice we can
throw things in when we feel like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
