jacek-lewandowski commented on code in PR #2064: URL: https://github.com/apache/cassandra/pull/2064#discussion_r1081198496
########## src/java/org/apache/cassandra/io/sstable/format/big/BigTableWriterBuilder.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.io.sstable.format.big; + +import org.apache.cassandra.db.lifecycle.LifecycleNewTracker; +import org.apache.cassandra.io.sstable.DataComponent; +import org.apache.cassandra.io.sstable.Descriptor; +import org.apache.cassandra.io.sstable.format.SortedTableWriterBuilder; +import org.apache.cassandra.io.util.SequentialWriter; +import org.apache.cassandra.utils.Throwables; + +public class BigTableWriterBuilder extends SortedTableWriterBuilder<RowIndexEntry, BigFormatPartitionWriter, BigTableWriter, BigTableWriterBuilder> +{ + private RowIndexEntry.IndexSerializer rowIndexEntrySerializer; + private BigTableWriter.IndexWriter indexWriter; + private SequentialWriter dataWriter; + private BigFormatPartitionWriter partitionWriter; + + public BigTableWriterBuilder(Descriptor descriptor) + { + super(descriptor); + } + + @Override + public SequentialWriter getDataWriter() + { + return dataWriter; + } + + @Override + public BigFormatPartitionWriter getPartitionWriter() + { + return partitionWriter; + } + + public RowIndexEntry.IndexSerializer getRowIndexEntrySerializer() + { + return rowIndexEntrySerializer; + } + + public BigTableWriter.IndexWriter getIndexWriter() + { + return indexWriter; + } + + @Override + protected BigTableWriter buildInternal(LifecycleNewTracker lifecycleNewTracker) + { + try + { + rowIndexEntrySerializer = new RowIndexEntry.Serializer(descriptor.version, getSerializationHeader()); + dataWriter = DataComponent.buildWriter(descriptor, Review Comment: I did it that way in order to avoid long arguments lists on constructor. Also having say, data file handle and partition writer passed as separate fields in the constructor would theoretically let pass a handle to a different file than the provided partition writer operates on. As far as I understand, those two parameters are inherently related and passing them always together (in a single builder) is more consistent to me. The resource fields are cleaned in finally block, so the builder can be safely reused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
