blambov commented on code in PR #2064:
URL: https://github.com/apache/cassandra/pull/2064#discussion_r1081292027
##########
src/java/org/apache/cassandra/db/compaction/Scrubber.java:
##########
@@ -742,6 +750,12 @@ public
FixNegativeLocalDeletionTimeIterator(UnfilteredRowIterator iterator, Outp
this.negativeLocalExpirationTimeMetrics =
negativeLocalDeletionInfoMetrics;
}
+ @Override
+ public UnfilteredRowIterator wrapped()
+ {
+ return iterator;
+ }
+
Review Comment:
looks good
##########
src/java/org/apache/cassandra/db/compaction/Scrubber.java:
##########
@@ -564,20 +565,27 @@ public ScrubResult(Scrubber scrubber)
/**
* During 2.x migration, under some circumstances rows might have gotten
duplicated.
* Merging iterator merges rows with same clustering.
- *
+ * <p>
* For more details, refer to CASSANDRA-12144.
*/
- private static class RowMergingSSTableIterator extends
WrappingUnfilteredRowIterator
+ private static class RowMergingSSTableIterator extends
UnmodifiableIterator<Unfiltered> implements WrappingUnfilteredRowIterator
Review Comment:
looks good
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableFormat.java:
##########
@@ -36,6 +36,9 @@
SSTableWriter.Factory getWriterFactory();
SSTableReader.Factory getReaderFactory();
+ boolean isKeyCacheSupported();
Review Comment:
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
