belliottsmith commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1094949442
##########
accord-core/src/main/java/accord/primitives/Txn.java:
##########
@@ -32,13 +32,26 @@
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
-import static accord.primitives.Routables.Slice.Overlapping;
-
public interface Txn
{
enum Kind
{
- Read, Write;
+ Read,
+ Write,
+
+ /**
+ * A pseudo-transaction whose deps represent the complete set of
transactions that may execute before it,
+ * without interfering with their execution.
+ *
+ * A SyncPoint is unique in that it agrees not only an executeAt but
also a precise collection of dependencies,
Review Comment:
Yes, but it’s slightly more than that: since an Accept round for a normal
transaction means it has (likely) taken a later executeAt the dependencies
aren’t enough for execution as they don’t include the full set of deps for the
higher executeAt - for that we use the dependencies returned in the Acceot
response
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
