aweisberg commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1094884582
##########
accord-core/src/main/java/accord/local/CommandStore.java:
##########
@@ -54,6 +63,36 @@ public int id()
return id;
}
+ protected void setRejectBefore(ReducingRangeMap<Timestamp> newRejectBefore)
+ {
+ this.rejectBefore = newRejectBefore;
+ }
+
+ Timestamp preaccept(TxnId txnId, Seekables<?, ?> keys, SafeCommandStore
safeStore)
+ {
+ NodeTimeService time = safeStore.time();
+ boolean isExpired = agent().isExpired(txnId, safeStore.time().now());
Review Comment:
I am just reacting to `isExpired` being reused for the result of
`rejectBefore`
If you want to call both of them expiration that's pretty reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
