bdeggleston commented on code in PR #33: URL: https://github.com/apache/cassandra-accord/pull/33#discussion_r1100815956
########## accord-core/src/main/java/accord/local/AsyncCommandStores.java: ########## @@ -1,92 +0,0 @@ -/* Review Comment: I think I’d meant to talk to you about this and never did. Some of the state tracking happening in C* was moved into Accord as explicit state changes in abstract base classes (ie: AbstractSafeCommandStore), and these changes were not compatible with the split sync/async class hierarchy. Since accord is meant to be async, I removed the sync class. I’m not sure this is necessary with the current state of the code. While we’re talking about it though, it seemed that these classes were meant to make sync and async operation a bit cleaner and remove some code duplication. Was there another goal that’s less obvious? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
