adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1106976807


##########
src/java/org/apache/cassandra/db/rows/Cell.java:
##########
@@ -108,7 +127,7 @@ public ByteBuffer buffer()
      * @return the cell local deletion time, or {@code NO_DELETION_TIME} if 
the cell is neither
      * a tombstone nor an expiring one.
      */
-    public abstract int localDeletionTime();
+    public abstract long localDeletionTime();

Review Comment:
   Also, `NativeCell#withUpdatedTimestampAndLocalDeletionTime`, 
`NativeCell#withUpdatedColumn` and `NativeCell#withSkippedValue` could also 
benefit from that `Cell#localDeletionTimeAsUnsignedInt` method to avoid the 
uint->long->uint conversion that the currently do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to