adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1107047993


##########
test/unit/org/apache/cassandra/db/CellTest.java:
##########
@@ -172,9 +172,6 @@ public void testValidate()
 
         // Invalid ttl
         assertInvalid(BufferCell.expiring(c, 0, -4, 4, bbs(4)));
-        // Cells with overflowed localExpirationTime are valid after 
CASSANDRA-14092

Review Comment:
   Instead of just removing the tests, we could verify that they are rejected 
with `value (-1) is outside the range for an unsigned integer value`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to