bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1109594423
##########
src/java/org/apache/cassandra/cql3/QueryOptions.java:
##########
@@ -53,6 +54,10 @@
public static final CBCodec<QueryOptions> codec = new Codec();
+ private static final int UNSET_NOWINSEC = Integer.MIN_VALUE;
+ // Guava uint counterpart to the above for serialization purposes. This
imposes a year 2186 max value
+ private static final int UNSET_NOWINSEC_GUAVA_UINT =
UnsignedInteger.MAX_VALUE.intValue() - 1;
Review Comment:
Well I'll disagree somehow here. Putting some thought into trying to make
your design friendlier is a perfectly good reason.Now if your ideas don't get
traction then so be it. I don't feel strongly about it. I'll run it through CI
next time I commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
