bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1109612827
##########
src/java/org/apache/cassandra/io/sstable/metadata/StatsMetadata.java:
##########
@@ -267,7 +271,24 @@ public int serializedSize(Version version, StatsMetadata
component) throws IOExc
size +=
EstimatedHistogram.serializer.serializedSize(component.estimatedPartitionSize);
size +=
EstimatedHistogram.serializer.serializedSize(component.estimatedCellPerPartitionCount);
size +=
CommitLogPosition.serializer.serializedSize(component.commitLogIntervals.upperBound().orElse(CommitLogPosition.NONE));
- size += 8 + 8 + 4 + 4 + 4 + 4 + 8 + 8; // mix/max timestamp(long),
min/maxLocalDeletionTime(int), min/max TTL, compressionRatio(double),
repairedAt (long)
+ size += 8 + 8; // mix/max timestamp(long)
+ if (version.hasLongLocalDeletionTime())
Review Comment:
Ok but I see you can comment and I'll be happy to reopen if I ever close
sthg and somebody disagrees.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
