bdeggleston commented on code in PR #2144: URL: https://github.com/apache/cassandra/pull/2144#discussion_r1113602521
########## src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java: ########## @@ -30,14 +30,17 @@ import accord.local.CommandStore; import accord.local.PreLoadContext; import accord.local.SafeCommandStore; +import accord.primitives.RoutableKey; import accord.primitives.Seekables; import accord.primitives.TxnId; +import accord.utils.Invariants; +import accord.utils.async.AsyncChains; import org.apache.cassandra.service.accord.AccordCommandStore; -import org.apache.cassandra.service.accord.AccordCommandStore.SafeAccordCommandStore; -import org.apache.cassandra.service.accord.api.PartitionKey; -import org.apache.cassandra.utils.concurrent.AsyncPromise; +import org.apache.cassandra.service.accord.AccordLiveCommand; +import org.apache.cassandra.service.accord.AccordLiveCommandsForKey; +import org.apache.cassandra.service.accord.AccordSafeCommandStore; -public abstract class AsyncOperation<R> extends AsyncPromise<R> implements Runnable, Function<SafeCommandStore, R>, BiConsumer<Object, Throwable> +public abstract class AsyncOperation<R> extends AsyncChains.Head<R> implements Runnable, Function<SafeCommandStore, R> Review Comment: The idea was that transient listeners support client requests, so the worst outcome of an eviction is a timed out request. I could see putting a minimum time bound on cache eviction that is >= request timeout. If we need finer grained control over this though, we should move it to another ticket / PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
