adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1120191633
##########
test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java:
##########
@@ -637,18 +637,18 @@ public void testGenerateSstables() throws Throwable
File ksDir = new File(LEGACY_SSTABLE_ROOT,
String.format("%s/legacy_tables", BigFormat.latestVersion));
ksDir.tryCreateDirectories();
- copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir);
+ copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
}
- public static void copySstablesFromTestData(String table, File ksDir)
throws IOException
+ public static void copySstablesFromTestData(String table, File ksDir,
String ks) throws IOException
Review Comment:
This adds a `ks` parameter instead of using `"legacy_tables"`. However, the
passed `ks` argument is always `"legacy_tables"`, so the change seems unneeded.
Perhaps we could replace the 21 repetitions of the string `"legacy_tables"`
by a `static final` class constant, make this method `private` and remove the
parameter:
```java
private static final String LEGACY_TABLES_KEYSPACE = "legacy_tables";
...
private static void copySstablesFromTestData(String table, File ksDir)
throws IOException
{
File cfDir = new File(ksDir, table);
cfDir.tryCreateDirectory();
for (File srcDir :
Keyspace.open(LEGACY_TABLES_KEYSPACE).getColumnFamilyStore(table).getDirectories().getCFDirectories())
{
for (File file : srcDir.tryList())
{
copyFile(cfDir, file);
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
