adelapena commented on code in PR #1891: URL: https://github.com/apache/cassandra/pull/1891#discussion_r1121953509
########## NEWS.txt: ########## @@ -1,9 +1,9 @@ -PLEASE READ: MAXIMUM TTL EXPIRATION DATE NOTICE (CASSANDRA-14092) ------------------------------------------------------------------- +PLEASE READ: MAXIMUM TTL EXPIRATION DATE NOTICE (CASSANDRA-14092 & CASSANDRA-14227) +----------------------------------------------------------------------------------- (General upgrading instructions are available in the next section) -The maximum expiration timestamp that can be represented by the storage engine is -2038-01-19T03:14:06+00:00, which means that inserts with TTL thatl expire after +The maximum expiration timestamp that can be represented by the storage engine has been +raised to 2106-02-07T06:28:14+00:00, which means that inserts with TTL that expire after Review Comment: This would be the value if `Cell.MAX_DELETION_TIME` were `CassandraUInt.maxValueAsLong() - 1`, which is the maximum that we can represent while leaving `CassandraUInt.maxValueAsLong()` for `Cell.NO_DELETION_TIME`. However `Cell.MAX_DELETION_TIME` currently is `CassandraUInt.maxValueAsLong() - 2` for leaving space for some unknown future use. If we are going to keep it that way, the formatted max timestamp mentioned here should be `2106-02-07T06:28:13+00:00`, one second earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
