belliottsmith commented on code in PR #33: URL: https://github.com/apache/cassandra-accord/pull/33#discussion_r1122045783
########## accord-core/src/main/java/accord/local/CommonAttributes.java: ########## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package accord.local; + +import accord.api.RoutingKey; +import accord.api.VisibleForImplementation; +import accord.primitives.PartialDeps; +import accord.primitives.PartialTxn; +import accord.primitives.Route; +import accord.primitives.TxnId; +import accord.utils.Invariants; +import com.google.common.collect.ImmutableSet; + +import java.util.Set; + +import static accord.utils.Utils.ensureImmutable; +import static accord.utils.Utils.ensureMutable; + +// TODO: remove or cleanup +public interface CommonAttributes +{ + TxnId txnId(); + Status.Durability durability(); + RoutingKey homeKey(); + RoutingKey progressKey(); + Route<?> route(); + PartialTxn partialTxn(); + PartialDeps partialDeps(); + Listeners.Immutable listeners(); + + default Mutable mutableAttrs() Review Comment: I don’t feel strongly about it, I just find mutableAttrs to slightly jar when reading. really the attrs are like a builder, which is not uncommon to see as a mutable version for constructing a new immutable object. another option would be `deconstruct`, or perhaps `builder` and move Mutable in the hierarchy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
