bereng commented on code in PR #1891: URL: https://github.com/apache/cassandra/pull/1891#discussion_r1122627686
########## NEWS.txt: ########## @@ -1,9 +1,9 @@ -PLEASE READ: MAXIMUM TTL EXPIRATION DATE NOTICE (CASSANDRA-14092) ------------------------------------------------------------------- +PLEASE READ: MAXIMUM TTL EXPIRATION DATE NOTICE (CASSANDRA-14092 & CASSANDRA-14227) +----------------------------------------------------------------------------------- (General upgrading instructions are available in the next section) -The maximum expiration timestamp that can be represented by the storage engine is -2038-01-19T03:14:06+00:00, which means that inserts with TTL thatl expire after +The maximum expiration timestamp that can be represented by the storage engine has been +raised to 2106-02-07T06:28:14+00:00, which means that inserts with TTL that expire after Review Comment: I don't think we're totally aligned here. - `-1` is to have room for the special value `LEGACY_OVERFLOWED_DELETION_TIME` - `-2` is so we don't collide with the above one - Yes I got 1s wrong good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
