bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1122659066
##########
src/java/org/apache/cassandra/db/RangeTombstoneList.java:
##########
@@ -58,12 +58,12 @@ public class RangeTombstoneList implements
Iterable<RangeTombstone>, IMeasurable
private ClusteringBound<?>[] starts;
private ClusteringBound<?>[] ends;
private long[] markedAts;
- private int[] delTimes;
+ private long[] delTimes;
Review Comment:
Yep the same can be said about every `long` TS in the codebase. But the
underlying idea in the PR is to have a `long` codebase where we don't burden
devs with dealing with units leaving that as a 'serialization' implementation
detail. Also to not spread uints across the codebase like wildfire. `Cell` and
`DeletionTime` being the exceptions.
At the end of the day we're trading a few bytes vs bit-wise operations.
Being range tombstones... finger in the air uneducated guess... it might not be
worth it but happy to be corrected :shrug: Like what's the usage here? Lot's of
operations with many overlaps or many non-overlapping ranges with very little
operations?...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
