smiklosovic commented on code in PR #2189:
URL: https://github.com/apache/cassandra/pull/2189#discussion_r1122756049
##########
src/java/org/apache/cassandra/service/DefaultFSErrorHandler.java:
##########
@@ -60,6 +60,7 @@ public void handleFSError(FSError e)
switch (DatabaseDescriptor.getDiskFailurePolicy())
{
+ case die:
Review Comment:
Is not it true that when policy is `die` and we reach this method, instead
of killing the jvm, you will only stop transports? There is this in
`cassandra.yaml`:
````
# die
# shut down gossip and client transports and kill the JVM for any fs
errors or
# single-sstable errors, so the node can be replaced.
````
As I read it, we should just kill whole JVM, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
