Runtian commented on code in PR #2189:
URL: https://github.com/apache/cassandra/pull/2189#discussion_r1123423301
##########
src/java/org/apache/cassandra/service/DefaultFSErrorHandler.java:
##########
@@ -60,6 +60,7 @@ public void handleFSError(FSError e)
switch (DatabaseDescriptor.getDiskFailurePolicy())
{
+ case die:
Review Comment:
Right, it is here to not reach the default so IllegalStateException will not
be thrown.
We can also just add die with ignore to do nothing, but I think it is better
to add die with stop and stop_paranoid so it tries to stop the transport and
gossip etc. Also added the similar change to `handleCorruptSSTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
